C++: Fix FP in cpp/comparison-of-identical-expressions
#7395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Dec 15, 2021
cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/templates.cpp
Outdated
Show resolved
Hide resolved
…flowCheck/templates.cpp Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Good point. I'll do an LGTM-diff query on our usual projects since I don't think the query is actually run as part of security-extended. |
|
No result changes on ~130 projects: https://lgtm.com/query/2133265528072233558/ |
|
Looks like we lose a (false positive) result for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7385.
Initially, I wanted to add this case to
Expr.isUnevaluatedsince that would make this fix apply more broadly. But I guess,Expr.isUnevaluatedshouldn't hold for things that are evaluated at compile-time only. So for now I've just special-cased this in the query containing the actual FP report.