C++: IR data flow from WriteSideEffectInstructions to partial ChiInstruction operands #3220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not catch data flows such as:
because there's a
ChiInstruction
between theWriteSideEffect
instruction and the load insink(b)
. (Note that this was a still caught by taint flow).This PR recovers these flows by inserting flow from write side effect instructions to the partial operand of
Chi
instructions, similar to how #3219 handles taint flows.