Skip to content

C++: add diff tests for DefaultTaintTracking #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 4, 2020
Merged

C++: add diff tests for DefaultTaintTracking #2695

merged 4 commits into from
Feb 4, 2020

Conversation

rdmarsh2
Copy link
Contributor

No description provided.

@rdmarsh2 rdmarsh2 added the C++ label Jan 24, 2020
@rdmarsh2 rdmarsh2 requested a review from a team January 24, 2020 21:51
@rdmarsh2
Copy link
Contributor Author

We may need to rerun tests for some open PRs after this is merged to avoid a semantic conflict

MathiasVP
MathiasVP reviewed Jan 26, 2020
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (apart from the missing autoformat in tainted_diff.ql)

@rdmarsh2 rdmarsh2 mentioned this pull request Jan 27, 2020
Merged
@jbj jbj merged commit c77a921 into github:master Feb 4, 2020
@rdmarsh2 rdmarsh2 deleted the default-taint-tracking-diff-test branch February 5, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP left review comments

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdmarsh2 @jbj @MathiasVP