Java: Fix bug in ConstantExpAppearsNonConstant. #20600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CodeQL query ConstantExpAppearsNonConstant where a previous fix accidentally introduced false positives. The change moves a filter condition from within the predicate definition to the main query's where clause to ensure it only removes problematic results without creating new ones.
- Moved the
ErrorTypefilter from theisConstantExppredicate to the main query where clause - This prevents the negation from appearing in a negated context, which was causing false positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #20546 was slightly buggy - the introduced negation also appeared in a negated context, so it accidentally introduced a bunch of new FPs. This PR moves the filter, so it only removes results without introducing new ones.