Skip to content

JS: Recognise that a less-than test is as good as a non-equal test for mitigating off-by-one array access #20423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smowton merged 3 commits into from
Sep 15, 2025
Merged

JS: Recognise that a less-than test is as good as a non-equal test for mitigating off-by-one array access #20423

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fb133a
Recognise that a less-than test is as good as a non-equal test for mi…
smowton Sep 12, 2025
f5780ae
Amend docstring
smowton Sep 12, 2025
db5c581
Change note
smowton Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change note
  • Loading branch information
@smowton
smowton committed Sep 12, 2025
commit db5c58180e38c19dde95d1327e680ca791b7536a
4 changes: 4 additions & 0 deletions javascript/ql/src/change-notes/2025-09-12-off-by-one.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Query `js/index-out-of-bounds` no longer produces a false-positive when a strictly-less-than check overrides a previous less-than-or-equal test.