QL4QL: Extend ql/inline-overlay-caller #19863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspersv
force-pushed
the
kaspersv/ql4ql-overlay-caller-q
branch
4 times, most recently
from
8e30984 to
49db3aa
Compare
kaspersv
force-pushed
the
kaspersv/ql4ql-overlay-caller-q
branch
from
49db3aa to
e1fc138
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the overlay[caller?] annotation in the inline-overlay-caller query, updating both the implementation and test expectations.
- Extend the query to recognize and skip
overlay[caller?]annotations - Update the warning message to suggest
overlay[caller?]alongsideoverlay[caller] - Define the new
CallerQArgandOverlayCallerQclasses in the AST
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ql/ql/test/queries/overlay/InlineOverlayCaller/Test.qll | Added a test predicate with overlay[caller?] |
| ql/ql/test/queries/overlay/InlineOverlayCaller/InlineOverlayCaller.expected | Updated expected warning to mention overlay[caller?] |
| ql/ql/src/queries/overlay/InlineOverlayCaller.ql | Excluded OverlayCallerQ annotations and updated the suggestion text |
| ql/ql/src/codeql_ql/ast/Ast.qll | Introduced CallerQArg and OverlayCallerQ classes |
ql/ql/test/queries/overlay/InlineOverlayCaller/InlineOverlayCaller.expected
Show resolved
Hide resolved
ginsbach
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
ql/inline-overlay-callerquery with support foroverlay[caller?]annotations.