Skip to content

C#: Improve auto-builder to better detect SDK references. #19289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Apr 11, 2025

In this PR we extend the auto builder heuristic detection logic for when to use dotnet to build a project.
There are tree ways to reference an Sdk, which is described here.

DCA doesn't show any changes to performance, build capabilities or alerts for the projects in our autobuild suite.

@michaelnebel michaelnebel force-pushed the csharp/improveautobuilder branch from bbb5a1c to f349048 Compare April 11, 2025 11:54
@michaelnebel michaelnebel marked this pull request as ready for review April 14, 2025 07:55
@michaelnebel michaelnebel requested a review from a team as a code owner April 14, 2025 07:55
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnebel michaelnebel merged commit 53c4b29 into github:main Apr 14, 2025
19 checks passed
@michaelnebel michaelnebel deleted the csharp/improveautobuilder branch April 14, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants