Rust: Handle type equality for a few more expression types #19026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the type equality predicate to propagate equal types for additional expression types.
- Removed outdated comments in MyEnum match arms in mod m6.
- Added test cases for if expression, match expression, and loop expression in mod m9.
Files not reviewed (5)
- rust/ql/lib/codeql/rust/controlflow/internal/Completion.qll: Language not supported
- rust/ql/lib/codeql/rust/controlflow/internal/ControlFlowGraphImpl.qll: Language not supported
- rust/ql/lib/codeql/rust/controlflow/internal/Splitting.qll: Language not supported
- rust/ql/lib/codeql/rust/elements/internal/IfExprImpl.qll: Language not supported
- rust/ql/lib/codeql/rust/internal/TypeInference.qll: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
paldepind
force-pushed
the
rust-expr-type-eq
branch
from
30e9d46 to
c17c045
Compare
Contributor
Author
|
DCA is looking fine I think (phew 😅). Missing call targets is down, 4 extra path resolution inconsistencies on Rust, and things look slightly slower but I guess that's because more types are inferred. |
Contributor
Actually, there appears to be no slowdown at all, when you look at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that extends the type equality predicate to propagate equal types for a few more expression types.