Skip to content

Rust: Implement TypeParam.to(Abbreviated)String #18755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Feb 13, 2025
Merged

Rust: Implement TypeParam.to(Abbreviated)String #18755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rust/ql/.generated.list
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion rust/ql/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions rust/ql/lib/codeql/rust/elements/internal/TypeParamImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// generated by codegen, remove this comment if you wish to edit this file
/**
* This module provides a hand-modifiable wrapper around the generated class `TypeParam`.
*
Expand All @@ -12,11 +11,16 @@ private import codeql.rust.elements.internal.generated.TypeParam
* be referenced directly.
*/
module Impl {
// the following QLdoc is generated: if you need to edit it, do it in the schema file
/**
* A TypeParam. For example:
* ```rust
* todo!()
* ```
*/
class TypeParam extends Generated::TypeParam { }
class TypeParam extends Generated::TypeParam {
override string toAbbreviatedString() { result = this.getName().getText() }

override string toString() { result = this.getName().getText() }
}
}
2 changes: 1 addition & 1 deletion rust/ql/test/extractor-tests/utf8/ast.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
| utf8_identifiers.rs:1:7:4:1 | GenericParamList |
| utf8_identifiers.rs:2:5:2:6 | ''\u03b2 |
| utf8_identifiers.rs:2:5:2:6 | LifetimeParam |
| utf8_identifiers.rs:3:5:3:5 | TypeParam |
| utf8_identifiers.rs:3:5:3:5 | \u03b3 |
| utf8_identifiers.rs:3:5:3:5 | \u03b3 |
| utf8_identifiers.rs:4:2:4:3 | ParamList |
| utf8_identifiers.rs:4:5:4:6 | StmtList |
Expand Down
8 changes: 4 additions & 4 deletions rust/ql/test/library-tests/path-resolution/path-resolution.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ resolvePath
| main.rs:188:19:188:32 | ...::MyStruct | main.rs:185:5:185:26 | struct MyStruct |
| main.rs:190:9:190:12 | self | main.rs:184:1:192:1 | mod m9 |
| main.rs:190:9:190:22 | ...::MyStruct | main.rs:185:5:185:26 | struct MyStruct |
| main.rs:200:12:200:12 | T | main.rs:197:7:197:7 | TypeParam |
| main.rs:205:12:205:12 | T | main.rs:204:14:204:14 | TypeParam |
| main.rs:200:12:200:12 | T | main.rs:197:7:197:7 | T |
| main.rs:205:12:205:12 | T | main.rs:204:14:204:14 | T |
| main.rs:207:7:209:7 | MyStruct::<...> | main.rs:195:5:201:5 | struct MyStruct |
| main.rs:208:9:208:9 | T | main.rs:204:14:204:14 | TypeParam |
| main.rs:208:9:208:9 | T | main.rs:204:14:204:14 | T |
| main.rs:211:9:211:16 | MyStruct | main.rs:195:5:201:5 | struct MyStruct |
| main.rs:221:17:221:19 | Foo | main.rs:216:5:216:21 | struct Foo |
| main.rs:222:9:222:11 | Foo | main.rs:218:5:218:15 | fn Foo |
Expand All @@ -115,7 +115,7 @@ resolvePath
| main.rs:246:9:246:12 | ...::C | main.rs:243:9:243:9 | C |
| main.rs:249:17:249:17 | S | main.rs:241:5:241:13 | struct S |
| main.rs:250:17:250:17 | C | main.rs:243:9:243:9 | C |
| main.rs:263:16:263:16 | T | main.rs:257:7:257:7 | TypeParam |
| main.rs:263:16:263:16 | T | main.rs:257:7:257:7 | T |
| main.rs:264:14:264:17 | Self | main.rs:255:5:265:5 | trait MyParamTrait |
| main.rs:264:14:264:33 | ...::AssociatedType | main.rs:259:9:259:28 | TypeAlias |
| main.rs:273:13:273:17 | crate | main.rs:1:1:302:2 | SourceFile |
Expand Down