Rust: fetch ungram and rust-analyzer code instead of checking it in #18319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The ungram file is now taken from the rust-analyzer dependencies pulled in by bazel * the grammar parsing code is not published, so it must be taken directly from rust-analyzer code. That part should be less prone to be updated than the ungram file, so it does not necessarily need to be in sync with the rust-analyzer version is used elsewhere. * both need some patches. The former is patched during build, the latter during loading in `MODULE.bazel`.
Contributor
There was a problem hiding this comment.
Copilot reviewed 121 out of 141 changed files in this pull request and generated no comments.
Files not reviewed (20)
- MODULE.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.always-assert-0.2.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.android_system_properties-0.1.5.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anyhow-1.0.94.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.atomic-0.6.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bstr-1.11.1.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bytemuck-1.20.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.camino-1.1.9.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.cargo-platform-0.1.9.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.cargo_metadata-0.18.1.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.cc-1.2.4.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chalk-derive-0.98.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chalk-recursive-0.98.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chalk-solve-0.98.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chrono-0.4.39.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap-4.5.23.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap_builder-4.5.23.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap_derive-4.5.18.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap_lex-0.7.4.bazel: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
aibaars
approved these changes
Dec 18, 2024
Contributor
aibaars
left a comment
aibaars
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODULE.bazel.bazel run //rust/ast-generator:inject_sourcescan be used to place the now missing sources in-tree to enable proper IDE support andcargobased tools. This is a developer convenience and is not required for the bazel build.