Skip to content

Conversation

@oscarsj
Copy link
Member

@oscarsj oscarsj commented Nov 27, 2024

Avoid running compile-queries.yml workflow on changes unrelated to queries (in particular on Kotlin extractor changes).

@oscarsj oscarsj requested a review from a team as a code owner November 27, 2024 17:37
- '*.ql'
- '*.qll'
- '**/qlpack.yml'
- '*.dbscheme'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't all the lines need a **/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscarsj oscarsj requested a review from igfoo November 27, 2024 18:35
@criemen
Copy link
Collaborator

criemen commented Nov 27, 2024

Is this correct? I do believe our qlucie-setup relies on compile-queries being run for external contributions.

@oscarsj
Copy link
Member Author

oscarsj commented Nov 28, 2024

Is this correct? I do believe our qlucie-setup relies on compile-queries being run for external contributions.

Good catch, indeed it does. It does rely also on QL-for-QL workflow (.github/workflows/ql-for-ql-build.yml) that has the following triggers:

on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

if I'm correct, it should be triggered for all PRs with a target branch main, so we wouldn't miss the compile-queries.yml worfklow, qlucie would still trigger the external checks.

Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that **.ql on actions is a shorthand for **/*.ql. LGTM!

@oscarsj oscarsj merged commit 647515b into main Nov 29, 2024
5 checks passed
@oscarsj oscarsj deleted the oscarsj/compile-queries-paths branch November 29, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants