Skip to content

Rust: Rename expr on CallExpr and LetExpr #18115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paldepind merged 2 commits into from
Nov 27, 2024
Merged

Rust: Rename expr on CallExpr and LetExpr #18115

paldepind merged 2 commits into from
Nov 27, 2024

Conversation

@paldepind
Copy link
Contributor

@paldepind paldepind commented Nov 26, 2024 •
edited
Loading

  • Rename expr on CallExpr to function. The Rust term for this seems to be "function operand" and in swift ApplyExpr also has a getFunction to do the same, so the name seems appropriate.
  • Rename expr on LetExpr to scrutinee. Similarly to for MatchExpr.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 26, 2024
@paldepind paldepind marked this pull request as ready for review November 26, 2024 16:53
@paldepind paldepind changed the title Rust: Renamed expr on CallExpr and LetExpr Rust: Rename expr on CallExpr and LetExpr Nov 27, 2024
@paldepind paldepind merged commit 46abb90 into github:main Nov 27, 2024
15 checks passed
@paldepind paldepind deleted the rust-rename-expr branch November 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paldepind @hvitved