Rust: add extended canonical paths on enum variants #18083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
|
|
||
| import codeql.rust.elements.Abi | ||
| import codeql.rust.elements.Addressable |
Check warning
Code scanning / CodeQL
Redundant import Warning
Comment on lines
+9
to
+13
| /** | ||
| * Something that can be addressed by a path. | ||
| * | ||
| * TODO: This does not yet include all possible cases. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style Warning
Comment on lines
+15
to
+19
| /** | ||
| * Something that can be addressed by a path. | ||
| * | ||
| * TODO: This does not yet include all possible cases. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style Warning
Contributor
|
|
hvitved
previously approved these changes
Nov 25, 2024
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM (needs to be rebased, though).
hvitved
previously approved these changes
Nov 25, 2024
hvitved
previously approved these changes
Nov 25, 2024
Contributor
Author
|
@hvitved so sorry, I forgot to merge this and it had conflicts again. Could you re-approve? I promise it's the last time 🙂 |
hvitved
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.