Rust: Setup inline flow test library #17959
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,4 +1,4 @@ | |||
| fn source() -> &'static str { | |||
| fn source(i: i64) -> &'static str { | |||
Check notice
Code scanning / CodeQL
Unused variable
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Missing a bindingset, otherwise LGTM.
| result = src.asExpr().(CallExpr).getArgList().getArg(0).toString() | ||
| } | ||
|
|
||
| string getArgString(DataFlow::Node src, DataFlow::Node sink) { |
There was a problem hiding this comment.
Missing bindingset[src, sink].
There was a problem hiding this comment.
What does the bindingset do here? From the documentation I thought that it was only to be used for predicates over infinite types. For several of the other language there is no bindingset annotation on getArgString. Go for instance. Should it ideally also be added there? Or is it not needed there for some reason?
There was a problem hiding this comment.
It is needed to avoid creating a Cartesian product. It should also be added for Go.
| } | ||
|
|
||
| string getArgString(DataFlow::Node src, DataFlow::Node sink) { | ||
| (if exists(getSourceArgString(src)) then result = getSourceArgString(src) else result = "") and |
There was a problem hiding this comment.
I know this was copied from Ruby, but the idiomatic way to write things like this is
result = getSourceArgString(src)
or
not exists(getSourceArgString(src)) and
result = ""
2 participants
Setup inline flow test library for Rust. It doesn't output anything, but it should once other things begin to work 😉