Skip to content

Conversation

@redsun82
Copy link
Contributor

@redsun82 redsun82 commented Nov 7, 2024

This allows to reuse a persistent target directory, either created by another extraction run or by a previous normal cargo build, cutting down on extraction time.

As an example running codeql database create -l rust db --source-root vm/vmgs/vmgs/ on openvmm, on my machine goes down from ~190s with the default settings to ~90s when running with a "warm" target directory, with a 50%+ speed up.

@redsun82 redsun82 requested a review from aibaars November 7, 2024 12:07
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 7, 2024
…tions

Also removed the now unused `extract_dependencies` one.
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@redsun82 redsun82 merged commit 9cea631 into main Nov 8, 2024
@redsun82 redsun82 deleted the redsun82/rust-target-dir branch November 8, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants