Skip to content

Conversation

@aschackmull
Copy link
Contributor

Found by speculative flow.

@aschackmull aschackmull requested a review from a team as a code owner September 27, 2024 09:30
@github-actions github-actions bot added the Java label Sep 27, 2024
@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,10,4284,259,99,,9,,,26
+    Java Standard Library,``java.*``,10,4285,259,99,,9,,,26
-    Totals,,312,25170,2635,404,16,128,33,1,409
+    Totals,,312,25171,2635,404,16,128,33,1,409
  • Changes to framework-coverage-java.csv:
- java.io,66,1,256,,,,,,,,,22,,,,,,,,,,,,,,,44,,,,,,,,,,,,,,,,,,,,,,1,,249,7
+ java.io,66,1,257,,,,,,,,,22,,,,,,,,,,,,,,,44,,,,,,,,,,,,,,,,,,,,,,1,,250,7

- ["java.io", "ByteArrayOutputStream", False, "writeTo", "", "", "Argument[this]", "Argument[0]", "taint", "manual"]
- ["java.io", "CharArrayReader", False, "CharArrayReader", "", "", "Argument[0]", "Argument[this]", "taint", "manual"]
- ["java.io", "CharArrayWriter", True, "toCharArray", "", "", "Argument[this]", "ReturnValue", "taint", "manual"]
- ["java.io", "CharArrayWriter", True, "toString", "()", "", "Argument[this]", "ReturnValue", "taint", "manual"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a df-generated model is examined and determined to be correct then we make the provenance df-manual. Perhaps we could do something similar for speculative flow, to keep track of where the model came from? You'd also have to update the validation code, where I see the existing options. sp or sf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether that's valuable - for now at least, all I got was a qualified name, which prompted me to have a look and add a manual model.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Nov 12, 2024
@aschackmull aschackmull merged commit d7fbf68 into github:main Nov 12, 2024
1 check passed
@aschackmull aschackmull deleted the java/chararraywriter-tostring branch November 12, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants