Rust: extract parse errors as diagnostics #17552
Conversation
aibaars
changed the title
| | does_not_compile.rs:2:13:2:12 | expected SEMICOLON | Extraction failed in does_not_compile.rs with error expected SEMICOLON | 2 | | ||
| | does_not_compile.rs:2:21:2:20 | expected SEMICOLON | Extraction failed in does_not_compile.rs with error expected SEMICOLON | 2 | | ||
| | does_not_compile.rs:2:26:2:25 | expected SEMICOLON | Extraction failed in does_not_compile.rs with error expected SEMICOLON | 2 | | ||
| | does_not_compile.rs:2:32:2:31 | expected field name or number | Extraction failed in does_not_compile.rs with error expected field name or number | 2 | |
There was a problem hiding this comment.
I'm surprised we don't get any results from error.rs (which contains compile_error!("An error!");).
There was a problem hiding this comment.
The line in error.rs isn't a syntax error.
There was a problem hiding this comment.
I suppose. I feel like it should show up somewhere (and is a cleaner test than does_not_compile.rs).
There was a problem hiding this comment.
The extractor currently only parses the code, and error.rs does not contain a syntax error.
I would expect an error to be reported once we implement macro expansion.
rust/ql/src/queries/summary/NumberOfFilesExtractedWithErrors.ql
Outdated
Show resolved
Hide resolved
rust/ql/src/queries/summary/NumberOfSuccessfullyExtractedFiles.ql
Outdated
Show resolved
Hide resolved
| (valid, invalid) | ||
| } else { | ||
| return (Cow::Borrowed(""), None); | ||
| }; |
There was a problem hiding this comment.
Is the special handling of the first chunk essentially an optimisation for the common case?
There was a problem hiding this comment.
No, it is a way to get the location of the first UTF8 decoding error, if any. If a file is complete garbage we don't want to generate a ton of useless decoding errors, one is enough.
There was a problem hiding this comment.
Although the Cow (copy-on-write) stuff is an optimisation for the common case that the input is entirely valid utf8 and no replacements are needed.
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
aibaars
force-pushed
the
aibaars/diagnostics
branch
2 times, most recently
from
60677e5 to
ca7b9e1
Compare
aibaars
force-pushed
the
aibaars/diagnostics
branch
from
ca7b9e1 to
5714811
Compare
Depends on #17543
This pull request add extraction of parse error messages, and adds some diagnostic queries.