Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add support for post-process provenance pretty-printing in .ql library-tests #17093

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Jul 29, 2024

Adds support for post-process provenance pretty-printing in .ql library-tests.

@github-actions github-actions bot added the Java label Jul 29, 2024
@@ -1,16 +1,24 @@
models
| 1 | Sink: android.app; Activity; true; bindServiceAsUser; ; ; Argument[0]; intent-redirection; manual |
| 1 | Source: testlib; TestSources; false; executeQuery; (String); ; ReturnValue; database; manual |
Copy link
Contributor Author

@jcogs33 jcogs33 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeats model number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussion elsewhere, it is fine to merge this PR before the fix for repeated model numbers.

@jcogs33 jcogs33 added the no-change-note-required This PR does not need a change note label Jul 29, 2024
@jcogs33 jcogs33 marked this pull request as ready for review July 30, 2024 15:14
@jcogs33 jcogs33 requested a review from a team as a code owner July 30, 2024 15:14
@jcogs33 jcogs33 requested a review from aschackmull July 30, 2024 15:15
@jcogs33 jcogs33 merged commit 05b0a3f into github:main Jul 31, 2024
13 checks passed
@jcogs33 jcogs33 deleted the jcogs33/java/provenance-postprocess-qltest-remaining-lib-tests branch July 31, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants