C++: Promote cpp/unsigned-difference-expression-compared-zero
to Code Scanning
#16982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All results flagged up by MRVA are either clear TPs, or FPs because of bad code. I consider "bad code" to be code such as:
and rewriting this to something like:
or even (if that was the intended meaning):
is much clearer and less error-prone. As an added bonus, all of these alerts should be easily auto-fixable.