Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Support more builtin operations #16951

Merged
merged 5 commits into from
Jul 11, 2024
Merged

C++: Support more builtin operations #16951

merged 5 commits into from
Jul 11, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jul 11, 2024

No description provided.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jul 11, 2024
@jketema jketema requested a review from a team as a code owner July 11, 2024 08:38
class BuiltInOperationIsReferenceable extends BuiltInOperation, @isreferenceable {
override string toString() { result = "__is_referenceable" }

override string getAPrimaryQlClass() { result = "BuiltInIsReferenceable" }

Check failure

Code scanning / CodeQL

Inconsistent getAPrimaryQlClass predicate Error

The getAPrimaryQlClass predicate
results in "BuiltInIsReferenceable"
instead of the class name "BuiltInOperationIsReferenceable".
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise this LGTM!

cpp/ql/lib/semmle/code/cpp/exprs/BuiltInOperations.qll Outdated Show resolved Hide resolved
MathiasVP
MathiasVP previously approved these changes Jul 11, 2024
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema jketema merged commit 87d9218 into github:main Jul 11, 2024
15 of 16 checks passed
@jketema jketema deleted the builtin-op branch July 11, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants