-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Adopt shared SSA data-flow integration #16937
Conversation
269c760
to
5ccc46d
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
e = DfInput::getARead(_) | ||
or | ||
DfInput::ssaDefAssigns(_, e) and | ||
isPost = false |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct. Warning
variable isPost
bc543bc
to
1090f52
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
e = DfInput::getARead(_) | ||
or | ||
DfInput::ssaDefAssigns(_, e) and | ||
isPost = false |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct. Warning
variable isPost
7280dbc
to
e17c067
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
e = DfInput::getARead(_) | ||
or | ||
exists(DefinitionExt def | | ||
DfInput::ssaDefAssigns(def, e) and | ||
hasCertainRead(def) and | ||
isPost = false | ||
) |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct. Warning
variable isPost
4ff0306
to
6290a2d
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
|
||
private newtype TNode = | ||
TParamNode(DfInput::Parameter p) { | ||
exists(WriteDefinition def | DfInput::ssaDefInitializesParam(def, p)) |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
in this argument
6290a2d
to
9263977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks plausible to me.
This PR adopts the newly introduced shared SSA data-flow integration layer.