-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Adopt shared SSA data-flow integration #16936
base: main
Are you sure you want to change the base?
Conversation
@@ -1118,3 +1055,64 @@ | |||
result = this.getSourceVariable().getEnclosingCallable() | |||
} | |||
} | |||
|
|||
private module DataFlowIntegrationInput implements Impl::DataFlowIntegrationInputSig { | |||
private import csharp as Cs |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
b5c4d66
to
6b1b308
Compare
2b175c6
to
df69c4e
Compare
5b70129
to
86f7735
Compare
86f7735
to
591b745
Compare
shared/ssa/codeql/ssa/Ssa.qll
Outdated
|
||
private newtype TNode = | ||
TParamNode(DfInput::Parameter p) { | ||
exists(WriteDefinition def | DfInput::ssaDefInitializesParam(def, p)) |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
in this argument
591b745
to
ac08fc5
Compare
exists(Guard g, Expr e, AbstractValue v | | ||
guardChecks(g, e, v) and | ||
g.controlsNode(result.getControlFlowNode(), e, v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this second disjunct not redundant now? Does it cover more than ssa variable reads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question: Yes, it covers more than SSA variable reads (it uses GVN, which--although it is unsound in general--is likely to produce valid guards).
ac08fc5
to
6506034
Compare
6506034
to
89a2381
Compare
This PR adopts the newly introduced shared SSA data-flow integration layer. A side-effect is that we get phi-input barrier guards for free, which had not previously been ported to C#.