-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Refactor test workflows #16927
base: main
Are you sure you want to change the base?
Go: Refactor test workflows #16927
Conversation
0bba2e8
to
2a1587e
Compare
4226a06
to
a90aee9
Compare
a90aee9
to
8ff5888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments on dispatch vs call.
Another point though: if we are investing in this workflow, wouldn't it make sense maybe to move the QL testing it to the internal repo amd the WFG and add it to QLucie? We would then catch problems of QL/semmle-code going out of sync.
Long term, I would keep in codeql only stylistic checks (like formatting) and checks ensuring local codeql development works (i.e. that building from codeql
with make
still works, as that wouldn't be checked in the internal repo).
I can understand if you want to postpone this (or leave it to the IDX team to do 🙂)
.github/workflows/go-tests.yml
Outdated
steps: | ||
- name: Dispatch test workflow | ||
shell: bash | ||
run: | | ||
gh workflow run "go-tests-linux.yml" --repo "${{ github.repository }}" --ref "${{ github.head_ref || github.ref_name }}" --json | ||
env: | ||
GH_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't a workflow call work here?
steps: | |
- name: Dispatch test workflow | |
shell: bash | |
run: | | |
gh workflow run "go-tests-linux.yml" --repo "${{ github.repository }}" --ref "${{ github.head_ref || github.ref_name }}" --json | |
env: | |
GH_TOKEN: ${{ github.token }} | |
uses: ./.github/go-tests-linux.yml | |
with: | |
ref: ${{ needs.prepare-go-tests.outputs.ref }} |
Otherwise I'm not sure the dispatched workflow will be very visible from the PR
.github/workflows/go-tests.yml
Outdated
steps: | ||
- name: Dispatch test workflow | ||
shell: bash | ||
run: | | ||
gh workflow run "go-tests-other-os.yml" --repo "${{ github.repository }}" --ref "${{ github.head_ref }}" --json | ||
env: | ||
GH_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
No description provided.