Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSA: Add BasicBlock.{getNode/1,length/0} to the input signature #16896

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jul 3, 2024

In preparation for #16884.

@@ -1809,7 +1809,7 @@
* Holds if `(bb, i)` contains a write to an iterator that may have been obtained
* by calling `begin` (or related functions) on the variable `v`.
*/
predicate variableWrite(IRBlock bb, int i, SourceVariable v, boolean certain) {
predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain) {

Check warning

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for certain, but the QLDoc mentions begin
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jul 3, 2024
@hvitved hvitved marked this pull request as ready for review July 3, 2024 12:33
@hvitved hvitved requested review from a team as code owners July 3, 2024 12:33
@hvitved hvitved requested a review from MathiasVP July 3, 2024 12:33
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is happy!

@hvitved hvitved merged commit da0909c into github:main Jul 3, 2024
54 checks passed
@hvitved hvitved deleted the ssa/dataflow-integration-prep branch July 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants