Go: remove flow step duplication in configs #16571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These names make more sense and match everywhere else that this function signature is used.
TaintTracking already adds taint steps for field reads
`localTaintStep` includes a lot of steps which are already part of value flow. Instead use `defaultAdditionalTaintStep`, which is just the extra steps that are added for taint tracking.
smowton
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplication of flow steps in additional flow steps added by configs was highlighted by #16511 and the new test results were accepted in #16562. This PR fixes them, so we aren't specifying additional flow steps in configs which duplicate existing flow steps.