Skip to content

Go: Make CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO on by default #15935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Mar 15, 2024

This PR enables CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO by default. This speeds up Go dependency extraction by only invoking go list once per logical workspace, rather than once per dependency.

This has been tested with a QA experiment, which showed no regressions caused by turning this on by default and improvements in extraction times across the board.

@mbg mbg self-assigned this Mar 15, 2024
@github-actions github-actions bot added the Go label Mar 15, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run QA -- last time this was checked (against LGTM!) there were regressions for some projects. Those may have been the non-modular projects, in which case this will no longer be an issue, but we should be sure.

@mbg
Copy link
Member Author

mbg commented Mar 18, 2024

@smowton I already ran a DCA with those specific projects that failed last time

@mbg mbg force-pushed the mbg/go/speed-up-dependencies branch from a7a8cbe to 0613446 Compare March 20, 2024 12:01
@mbg mbg marked this pull request as ready for review March 20, 2024 12:05
@mbg mbg requested a review from a team as a code owner March 20, 2024 12:05
@mbg mbg changed the title Go: Remove CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO check Go: Make CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO on by default Mar 20, 2024
@mbg mbg merged commit 616015f into main Mar 20, 2024
@mbg mbg deleted the mbg/go/speed-up-dependencies branch March 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants