Skip to content

Data flow: Cache viableCallableExt #15582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Feb 12, 2024

viableCallableExt is called in resolveReturn and resolveCall, so it should to be cached.

@hvitved hvitved force-pushed the dataflow/cache-viable-callable-ext branch 2 times, most recently from d241cb2 to bc8761c Compare February 13, 2024 20:06
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Feb 13, 2024
@hvitved hvitved marked this pull request as ready for review February 13, 2024 20:07
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@aschackmull aschackmull merged commit 393251d into github:main Feb 14, 2024
@hvitved hvitved deleted the dataflow/cache-viable-callable-ext branch February 19, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFlow Library no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants