Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Swift: separate installation of dependencies and autobuilding" #15305

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Revert "Swift: separate installation of dependencies and autobuilding" #15305

merged 1 commit into from
Jan 12, 2024

Conversation

AlexDenisov
Copy link
Contributor

This reverts commit dd13ea3.

Reverting #15116 as it caused regression.

@AlexDenisov AlexDenisov requested a review from a team as a code owner January 12, 2024 11:35
@github-actions github-actions bot added the Swift label Jan 12, 2024
geoffw0
geoffw0 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The CI failure I think is to do with a new check for upgrade scripts. It doesn't appear to relate to the changes here.

Missing delete directives for the tables [unknown_locations, method_ref_exprs] removed in the new dbscheme.

@alexet alexet merged commit b2f1fbe into codeql-cli-2.16.0 Jan 12, 2024
10 of 11 checks passed
@alexet alexet deleted the alexdenisov/revert-swift-change branch January 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexDenisov @geoffw0 @alexet