C++: Relax the dbscheme for link_targets/2
#14897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d10c
added
the
depends on internal PR
d10c
changed the title
link_targets/2
d10c
force-pushed
the
d10c/relax-cpp-dbscheme
branch
2 times, most recently
from
b0f65e2 to
cdd7cf2
Compare
d10c
force-pushed
the
d10c/relax-cpp-dbscheme
branch
from
8002bd1 to
ce803ac
Compare
|
Since this changes the dbscheme, would you mind running some DCA on this (with db caching off, and the submodule pointer taken from CodeQL). Please also turn on dataset check. |
d10c
force-pushed
the
d10c/relax-cpp-dbscheme
branch
2 times, most recently
from
9354b84 to
e70af14
Compare
jketema
approved these changes
Nov 30, 2023
d10c
force-pushed
the
d10c/relax-cpp-dbscheme
branch
from
e70af14 to
66c0a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
--no-linkage-aware-importflag can lead to DB-CHECK failures due to multiple link_targets/2 entries with the same ID, so removing theuniqueconstraint on the ID is one way to fix it.This PR will have to be merged with the failing
all-platforms/codeql-cli/option-linkage-aware-import/with-flag-disabledintegration test, because that test is updated in the corresponding internal PR.