JS: recognize tagged template literals as DataFlow::CallNode
#14405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2023
asgerf
reviewed
Oct 11, 2023
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
LGTM with a minor nit in the comment
Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by two recent external contributions that noticed the lack of call-edges to/from tagged template literals. (First, second).
The implementation is fairly straight forward.
The constant template elements of the tagged template literal are not modeled (the
fooandbarinfunc`foo${exp)bar`;)There was a performance issue, which was fixed by adding some more
cache.An evaluation shows neutral performance and some new call-edges and sinks (new sinks from recognizing more DOM nodes).