Variable capture: allow arbitrary data-flow nodes to be the source of a write #14048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicate
VariableWrite.getSource()
returned anExpr
, which is problematic for cases where there does not exist an explicit expression for the right-hand side.Some cases where this happens:
for (String x : array) {...}
writes tox
but there is no expression for the right-hand side.let { x, y } = foo()
contains a write tox
andy
, but neither variable has anExpr
for its right-hand side.x++
it varies between languages exactly how this works, but at least for JS, there is no AST node corresponding to the value that gets assigned tox
.This PR replaces
Expr getSource()
with aclass VariableWriteSourceNode
to represent the source of a write. The language implementation is free to map this node to an arbitrary data-flow node, whereas before it was forced to map it to an expression node.