Java: Make the barrier in java/potentially-weak-cryptographic-algorithm less restrictive #13856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hm less restrictive.
atorralba
reviewed
Jul 31, 2023
|
DCA looks fine. I've checked 3 of the projects that failed locally and they were fine as well (no result nor perf changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current barrier was phrased negatively, so it was catching and blocking all sorts of nodes - in particular it was effectively disabling field flow, which in the context of #13478 also means disabling capture flow. This seems unintentional, and I hope we can achieve most of the intended effect with a less restrictive and positively phrased barrier that similarly blocks flow through very generic code without getting into performance trouble.