Java: Support Argument[this] and parameters of bodiless interface methods in framework mode metadata extraction #13823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaeluka
changed the title
kaeluka
force-pushed
the
kaeluka/support-argument-this-in-frameworkmode-metadata-extraction
branch
from
f56aff4 to
b5862ae
Compare
…, so we can support both Argument[this] and interface-method parameters
kaeluka
force-pushed
the
kaeluka/support-argument-this-in-frameworkmode-metadata-extraction
branch
from
b5862ae to
8ed773b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@atorralba — the one integration test that passed was a fluke, I think (I restarted it). With that, the PR is ready for review. Are you able to do that? You've seen most of the implementation already. Thank you for your help, and also thanks to @aschackmull for the valuable input! |
kaeluka
deleted the
kaeluka/support-argument-this-in-frameworkmode-metadata-extraction
branch
kaeluka
added a commit
that referenced
this pull request
Jul 28, 2023
kaeluka
added a commit
that referenced
this pull request
Jul 28, 2023
In PR #13823, we had rewritten the endpoints that are being considered for framework mode. We used to use `DataFlow::ParameterNode` as endpoints. However, `ParameterNode`s do not exist for the implicit `this` parameter; they also do not exist for bodiless interface-methods. In PR #13823, we forgot to model that `this` only exists for non-static methods and to only consider parameters that we have source code for.
kaeluka
added a commit
that referenced
this pull request
Aug 1, 2023
kaeluka
added a commit
that referenced
this pull request
Aug 1, 2023
In PR #13823, we had rewritten the endpoints that are being considered for framework mode. We used to use `DataFlow::ParameterNode` as endpoints. However, `ParameterNode`s do not exist for the implicit `this` parameter; they also do not exist for bodiless interface-methods. In PR #13823, we forgot to model that `this` only exists for non-static methods and to only consider parameters that we have source code for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExplicitParameterNodes in framework mode, but skipped thethisparameter. This PR fixes the problem. I'll add a test case to the currently open test PR once this is merged.DataFlow::ParameterNodetypes local to the automodel code (if needed).