Skip to content

Conversation

@yoff
Copy link
Contributor

@yoff yoff commented Mar 9, 2023

We could handle this case specially, by having
a different implementation for for, but the
wider issue would remain.

this illustrates that the function implementing
the comprehension does not capture `mod_local`.

We could handle this case specially, by having
a different implementation for `for`, but the
wider issue would remain.
@yoff yoff requested a review from a team as a code owner March 9, 2023 11:13
@yoff yoff requested review from tausbn and removed request for a team March 9, 2023 11:13
@github-actions github-actions bot added the Python label Mar 9, 2023
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@yoff yoff merged commit 17c9ba9 into github:main Mar 20, 2023
@yoff
Copy link
Contributor Author

yoff commented Mar 20, 2023

Just realised that the test file is not added to validTest.py. Perhaps we should have a more automated way of keeping that up to date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants