Skip to content

Ruby: Fix string comparison barrier guard #12052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

hmac
Copy link
Contributor

@hmac hmac commented Feb 1, 2023

strNode was not properly restricted for some cases. Evaluation shows that we catch a few more TPs, probably because we've removed some (incorrect) guards to flow.

`strNode` was not properly restricted for some cases.
@github-actions github-actions bot added the Ruby label Feb 1, 2023
@hmac hmac added the no-change-note-required This PR does not need a change note label Feb 1, 2023
@hmac hmac marked this pull request as ready for review February 1, 2023 03:40
@hmac hmac requested a review from a team as a code owner February 1, 2023 03:40
Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely missed this in my initial review, fix LGTM.

@hmac hmac merged commit d671cc6 into github:main Feb 1, 2023
@hmac hmac deleted the barrier-guard-fix branch April 29, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants