Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: Exclude .kt files from serializable inner class query #11299

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Kotlin: Exclude .kt files from serializable inner class query #11299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
782c82a
Kotlin: Add test case for non serializable inner class query
tamasvajk Nov 16, 2022
7a0e248
Exclude .kt files from serializable inner class query
tamasvajk Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/ql/src/Likely Bugs/Serialization/NonSerializableInnerClass.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ predicate exceptions(NestedClass inner) {

from NestedClass inner, Class outer, string advice
where
inner.fromSource() and
inner.getFile().isJavaSourceFile() and
isSerializable(inner) and
outer = enclosingInstanceType+(inner) and
not isSerializable(outer) and
Expand Down
Empty file added java/ql/test/kotlin/query-tests/NonSerializableInnerClass/NonSerializableInnerClass.expected
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions java/ql/test/kotlin/query-tests/NonSerializableInnerClass/NonSerializableInnerClass.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Likely Bugs/Serialization/NonSerializableInnerClass.ql
11 changes: 11 additions & 0 deletions java/ql/test/kotlin/query-tests/NonSerializableInnerClass/NonSerializableInnerClassTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import java.io.Serializable

class A {
class X : Serializable {
}
}

class B {
inner class X : Serializable {
}
}