Skip to content

Python: Rewrite type trackers #10634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Sep 29, 2022

While looking through our existing custom type trackers, I found these two that we already have the means to rewrite.

we have the option to use `regex.getAValueReachingSink`
rather than `regex.asSink`, but it will likely be used as a
sink for data flow.
There are several other clean ups I would like to do in this file,
but this can wait until we promote the query.
@yoff yoff added the no-change-note-required This PR does not need a change note label Sep 29, 2022
@yoff yoff requested a review from a team as a code owner September 29, 2022 18:34
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@codeql-ci codeql-ci merged commit b66e5c5 into github:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants