Skip to content

python: rewrite CatchingBaseException from points-to to API graph #10266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

python: rewrite CatchingBaseException from points-to to API graph #10266

merged 1 commit into from
Sep 19, 2022

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Sep 1, 2022

No description provided.

@yoff yoff requested a review from a team as a code owner September 1, 2022 21:00
@github-actions github-actions bot added the Python label Sep 1, 2022
tausbn
tausbn approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should figure out whether a change note is required (I would lean towards doing a single change note once we've done a bunch of these rewrites).

@yoff
Copy link
Contributor Author

yoff commented Sep 2, 2022

We should figure out whether a change note is required (I would lean towards doing a single change note once we've done a bunch of these rewrites).

Agreed. Can we do just one? Should we make it a single PR, then?

@tausbn
Copy link
Contributor

tausbn commented Sep 2, 2022

Agreed. Can we do just one? Should we make it a single PR, then?

I think keeping the query rewrites as separate PRs is probably best. We should just add the no-change-note-required This PR does not need a change note label, and then put the change note in a separate PR at a later date.

@tausbn tausbn added the no-change-note-required This PR does not need a change note label Sep 2, 2022
@codeql-ci codeql-ci merged commit 36f8b05 into github:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoff @tausbn @codeql-ci