Skip to content

python: port UnguardedNextInIterator from points-to to API graph #10265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2022

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Sep 1, 2022

  • values are identified via API::builtin
  • points-to is approximated by getAValueReachableFromSource
  • adds a version check to only alert < 3.5

- values are identified via `API::builtin`
- `points-to` is approximated by `getAValueReachableFromSource`
@yoff yoff requested a review from a team as a code owner September 1, 2022 20:49
@github-actions github-actions bot added the Python label Sep 1, 2022
and attempt to set version for tests
@yoff yoff added the no-change-note-required This PR does not need a change note label Sep 3, 2022
@calumgrant
Copy link
Contributor

Rewrite as a Python 2 check.

since
- Python 3 is ok from 3.7 onwards
- support for Python 3.6 was just dropped
- we do not actually know the minor version of the analysed code
  (only of the extractor)
@codeql-ci codeql-ci merged commit ed4b64b into github:main Sep 19, 2022
@yoff yoff deleted the python/port-UnguardedNextInGenerator branch September 19, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants