Open
Description
In the telemetry code for the python extractor (ql/python/extractor/semmle/logging.py
) class member names shadow the setter function.
For example in:
class Source(StructuredLogObject):
def __init__(self, id, name, extractorName="python"):
self.id = id
self.name = name
self.extractorName = extractorName
def extractorName(self, extractorName):
self.extractorName = extractorName
return self
The member self.extractorName
shadows function def extractorName
.
This happens in classes: Source
, Visibility
and Location
.
I suggest to change the setters to with_ParameterName
as happens in the class DiagnosticMessage
.