Write-only container query: account for implicitly-initialised variables

github · Nov 30, 2023 · 9177409 · 9177409
1 parent bb6e044
commit 9177409
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql b/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
@@ -39,6 +39,6 @@ where
   ) and
   // Also, any value that `v` is initialized to is a new container,
   forall(Expr e | e = v.getAnAssignedValue() | e instanceof ClassInstanceExpr) and
-  // and `v` is not implicitly initialized by a for-each loop.
-  not exists(EnhancedForStmt efs | efs.getVariable().getVariable() = v)
+  // and `v` is not implicitly initialized
+  not v.(LocalVariableDecl).getDeclExpr().hasImplicitInit()
 select v, "The contents of this container are never accessed."