Skip to content

Commit

Permalink
fixing that I put a type on the wrong thing in the alert-message
Browse files Browse the repository at this point in the history
  • Loading branch information
@erik-krogh
erik-krogh committed Apr 8, 2024
1 parent 018b066 commit 8cb6598
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Arithmetic/InformationLoss.ql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,5 @@ where
v = a.getDest()
)
select a,
"Implicit cast of $@ to narrower destination type " + a.getDest().getType().getName() + ".", v,
"source type " + e.getType().getName()
"Implicit cast of source type " + e.getType().getName() + " to narrower destination type $@.", v,
a.getDest().getType().getName()
8 changes: 4 additions & 4 deletions java/ql/test/query-tests/security/CWE-190/semmle/tests/InformationLoss.expected
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
| Test.java:68:5:68:25 | ...+=... | Implicit cast of $@ to narrower destination type int. | Test.java:64:4:64:13 | int i | source type long |
| Test.java:87:4:87:9 | ...+=... | Implicit cast of $@ to narrower destination type int. | Test.java:81:4:81:13 | int i | source type long |
| Test.java:289:5:289:30 | ...+=... | Implicit cast of $@ to narrower destination type int. | Test.java:285:4:285:27 | int[] arr | source type long |
| Test.java:293:7:293:44 | ...+=... | Implicit cast of $@ to narrower destination type int. | Test.java:293:7:293:24 | ...[...] | source type long |
| Test.java:68:5:68:25 | ...+=... | Implicit cast of source type long to narrower destination type $@. | Test.java:64:4:64:13 | int i | int |
| Test.java:87:4:87:9 | ...+=... | Implicit cast of source type long to narrower destination type $@. | Test.java:81:4:81:13 | int i | int |
| Test.java:289:5:289:30 | ...+=... | Implicit cast of source type long to narrower destination type $@. | Test.java:285:4:285:27 | int[] arr | int |
| Test.java:293:7:293:44 | ...+=... | Implicit cast of source type long to narrower destination type $@. | Test.java:293:7:293:24 | ...[...] | int |

0 comments on commit 8cb6598

Please sign in to comment.