Exclude .kt files from serializable inner class query

github · Nov 16, 2022 · 7a0e248 · 7a0e248
1 parent 782c82a
commit 7a0e248
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/java/ql/src/Likely Bugs/Serialization/NonSerializableInnerClass.ql b/java/ql/src/Likely Bugs/Serialization/NonSerializableInnerClass.ql
@@ -77,7 +77,7 @@ predicate exceptions(NestedClass inner) {
 
 from NestedClass inner, Class outer, string advice
 where
-  inner.fromSource() and
+  inner.getFile().isJavaSourceFile() and
   isSerializable(inner) and
   outer = enclosingInstanceType+(inner) and
   not isSerializable(outer) and

diff --git a/java/ql/test/kotlin/query-tests/NonSerializableInnerClass/NonSerializableInnerClass.expected b/java/ql/test/kotlin/query-tests/NonSerializableInnerClass/NonSerializableInnerClass.expected
@@ -1,2 +0,0 @@
-| NonSerializableInnerClassTest.kt:4:3:5:3 | X | Serializable inner class of non-serializable class $@. Consider making the class static or implementing readObject() and writeObject(). | NonSerializableInnerClassTest.kt:3:1:6:1 | A | A |
-| NonSerializableInnerClassTest.kt:9:3:10:3 | X | Serializable inner class of non-serializable class $@. Consider making the class static or implementing readObject() and writeObject(). | NonSerializableInnerClassTest.kt:8:1:11:1 | B | B |
Original file line number	Diff line number	Diff line change
		@@ -1,2 +0,0 @@
		\| NonSerializableInnerClassTest.kt:4:3:5:3 \| X \| Serializable inner class of non-serializable class $@. Consider making the class static or implementing readObject() and writeObject(). \| NonSerializableInnerClassTest.kt:3:1:6:1 \| A \| A \|
		\| NonSerializableInnerClassTest.kt:9:3:10:3 \| X \| Serializable inner class of non-serializable class $@. Consider making the class static or implementing readObject() and writeObject(). \| NonSerializableInnerClassTest.kt:8:1:11:1 \| B \| B \|