Add `Memory4` package by jeongsoolee09 · Pull Request #1029 · github/codeql-coding-standards

jeongsoolee09 · 2026-02-06T00:07:56Z

Description

Add Memory4 package.

High-level overview

M0-2-1 (AUTOSAR C++):
- DoNotPassAliasedPointerToParam
- ObjectAssignedToAnOverlappingObject (Factored out)
RULE-19-1 (MISRA C):
- ObjectAssignedToAnOverlappingObject (Factored out)
- ObjectCopiedToAnOverlappingObject (Factored out)
RULE-8-18-1 (MISRA C++):
- ObjectCopiedToAnOverlappingObject (Imports factored-out shared query)
- ObjectAssignedToAnOverlappingObject (Imports factored-out shared query)

Step-by-step process overview

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- RULE-8-18-1
Queries have been modified for the following rules:
- M0-2-1
- RULE-19-1

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Copilot

Pull request overview

This PR adds the Memory4 package for MISRA C++ and refactors shared query implementations for detecting overlapping object operations across multiple coding standards (MISRA C, MISRA C++, and AUTOSAR C++).

Changes:

Adds new Memory4 package for MISRA C++ RULE-8-18-1
Refactors ObjectAssignedToAnOverlappingObject and ObjectCopiedToAnOverlappingObject queries into shared implementations
Updates existing queries in Representation (AUTOSAR C++) and Contracts7 (MISRA C) packages to use the new shared implementations

Reviewed changes

Copilot reviewed 37 out of 40 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
rules.csv	Updates RULE-8-18-1 package assignment
rule_packages/cpp/Memory4.json	New package definition for MISRA C++ Memory4 queries
rule_packages/cpp/Representation.json	Updates query naming to include suffix and shared implementation reference
rule_packages/c/Contracts7.json	Updates query naming to include suffix and shared implementation reference
cpp/common/src/codingstandards/cpp/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.qll	New shared implementation for overlapping assignment detection
cpp/common/src/codingstandards/cpp/rules/objectcopiedtoanoverlappingobject/ObjectCopiedToAnOverlappingObject.qll	Refactored shared implementation for overlapping copy detection
cpp/common/src/codingstandards/cpp/exclusions/cpp/Memory4.qll	New exclusion metadata for Memory4 package
cpp/common/src/codingstandards/cpp/exclusions/cpp/Representation.qll	Updated query references for renamed queries
cpp/common/src/codingstandards/cpp/exclusions/c/Contracts7.qll	Updated query references for renamed queries
cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll	Added Memory4 package integration
cpp/misra/src/rules/RULE-8-18-1/*	New MISRA C++ query implementations
cpp/autosar/src/rules/M0-2-1/*	Refactored AUTOSAR C++ query to use shared implementation
c/misra/src/rules/RULE-19-1/*	Refactored MISRA C query to use shared implementation
/test/	Updated test infrastructure for all affected queries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T00:11:52Z

rule_packages/cpp/Memory4.json

+      },
+      "queries": [
+        {
+            "description": "Copying a member of a union to another causes undefined behavior.",


The description says "Copying a member of a union to another" which is grammatically incorrect. It should be "Copying a member of a union to another member" for clarity.

Copilot · 2026-02-06T00:11:52Z

cpp/misra/src/rules/RULE-8-18-1/ObjectAssignedToAnOverlappingObjectMisraCpp.ql

+/**
+ * @id cpp/misra/object-assigned-to-an-overlapping-object-misra-cpp
+ * @name RULE-8-18-1: A member of a union must not be copied to its another member
+ * @description Copying a member of a union to another causes undefined behavior.


The description says "Copying a member of a union to another" which is grammatically incorrect. It should be "Copying a member of a union to another member" for clarity.

Copilot · 2026-02-06T00:11:52Z

...ndards/cpp/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.qll

+  exists(Expr lhs, Expr rhs |
+    lhs.getType() instanceof Union and
+    rhs.getType() instanceof Union and
+    lhs = getAQualifier(assignExpr.getLValue()) and
+    rhs = getAQualifier(assignExpr.getRValue()) and
+    globalValueNumber(lhs) = globalValueNumber(rhs) and
+    valuerhs = assignExpr.getRValue() and
+    valuelhs = assignExpr.getLValue() and // a.b.c == ((a.b).c)
+    overlaps(valuelhs, valuerhs) and
+    message = "An object $@ assigned to overlapping object $@." and
+    valuelhsTargetName = valuelhs.getTarget().getName() and
+    valuerhsTargetName = valuerhs.getTarget().getName()
+  )


The query predicate is missing the exclusion check. The commented code shows that the isExcluded check should be included, but it's not present in the actual implementation. This means the query will not respect user-defined exclusions.

rules.csv

Copilot · 2026-02-06T00:11:53Z

rule_packages/cpp/Memory4.json

+        {
+          "description": "Copying a slice of an array to an overlapping region of the same array causes undefined behavior.",
+          "kind": "problem",
+          "name": "An slice of an array must not be copied to an overlapping region of itself",


There is a grammatical error in the query name. It should be "A slice of an array" not "An slice of an array". The article "An" is incorrect before "slice".

Copilot · 2026-02-06T00:11:53Z

cpp/misra/src/rules/RULE-8-18-1/ObjectCopiedToAnOverlappingObjectMisraCpp.ql

@@ -0,0 +1,24 @@
+/**
+ * @id cpp/misra/object-copied-to-an-overlapping-object-misra-cpp
+ * @name RULE-8-18-1: An slice of an array must not be copied to an overlapping region of itself


There is a grammatical error in the query name. It should be "A slice of an array" not "An slice of an array". The article "An" is incorrect before "slice".

jeongsoolee09 added 4 commits February 5, 2026 18:36

Prepare rule description files

5f91c48

Update rules.csv

69ad124

Add package files and factor out shared code

b9cbb1c

Factor out test codes

5b64360

Copilot AI review requested due to automatic review settings February 6, 2026 00:07

Copilot started reviewing on behalf of jeongsoolee09 February 6, 2026 00:08 View session

Fix number from Memory5 to Memory4

0c62235

Copilot AI reviewed Feb 6, 2026

View reviewed changes

jeongsoolee09 self-assigned this Feb 6, 2026

jeongsoolee09 requested a review from MichaelRFairhurst February 6, 2026 00:15

jeongsoolee09 added 2 commits February 5, 2026 19:17

Fix formatting issues

f3fdbea

Apply suggestions from Copilot

c91971c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Memory4` package#1029

Add `Memory4` package#1029
jeongsoolee09 wants to merge 7 commits intomainfrom
jeongsoolee09/MISRA-C++-Memory4

jeongsoolee09 commented Feb 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jeongsoolee09 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

High-level overview

Step-by-step process overview

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jeongsoolee09 commented Feb 6, 2026 •

edited

Loading