Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into v1 #965

Merged
merged 34 commits into from
Mar 7, 2022
Merged

Merge main into v1 #965

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
507795f
Update changelog and version after v1.1.3
invalid-email-address Feb 23, 2022
949eeb2
1.1.4
invalid-email-address Feb 23, 2022
9169d24
Update checked-in dependencies
invalid-email-address Feb 23, 2022
360221e
Merge pull request #947 from github/mergeback/v1.1.3-to-main-75f07e7a
aeisenberg Feb 23, 2022
42af723
Revert "Merge pull request #869 from github/edoardo/windows-11-error"
edoardopirovano Feb 24, 2022
438f654
Merge pull request #948 from github/edoardo/revert-windows-11
edoardopirovano Feb 24, 2022
4e02f8e
Bump removeNPMAbsolutePaths from 2.0.0 to 3.0.0
dependabot[bot] Feb 24, 2022
0da8152
Update checked-in dependencies
invalid-email-address Feb 24, 2022
117a67b
Merge pull request #949 from github/dependabot/npm_and_yarn/removeNPM…
henrymercer Feb 24, 2022
162ecaf
Update default CodeQL bundle version to 2.8.2
hmakholm Feb 25, 2022
8ec6a84
Expand PR checks to cover `windows-2022`
edoardopirovano Feb 28, 2022
2531390
Merge pull request #950 from github/hmakholm/pr/2.8.2
hmakholm Feb 28, 2022
86940df
Delete the results directory in between runs.
chrisgavin Feb 28, 2022
d63f798
Retry directory deletion to avoid Windows file locking issues.
chrisgavin Feb 28, 2022
938e0a0
Add `retryDelay` and a type cast to make it work.
chrisgavin Feb 28, 2022
b1c781d
Merge pull request #955 from github/delete-results-directory
chrisgavin Feb 28, 2022
fa19286
Merge pull request #954 from github/edoardo/expand-tests
edoardopirovano Mar 1, 2022
07990f0
Revert "Revert "Use `--codescanning-config` flag of CLI""
edoardopirovano Mar 1, 2022
527d515
Bump version flag for using `--codescanning-config` flag
edoardopirovano Mar 1, 2022
e4766c8
Merge pull request #957 from github/edoardo/reuse-codescanning-config
edoardopirovano Mar 2, 2022
47dd636
Fix link to docs
daniel-beck Mar 2, 2022
3615d8a
Add runner OS and arch to status report
cklin Mar 2, 2022
870dbaa
Use getRequiredEnvParam()
cklin Mar 2, 2022
75e4d9f
Bump @actions/artifact from 0.5.2 to 1.0.0
dependabot[bot] Mar 3, 2022
4154eaf
Update checked-in dependencies
invalid-email-address Mar 3, 2022
5e27f57
Merge pull request #961 from github/dependabot/npm_and_yarn/actions/a…
aeisenberg Mar 3, 2022
401a76f
Add runner OS release to status report
cklin Mar 3, 2022
939659c
Merge pull request #959 from cklin/report-runner-os-arch
cklin Mar 3, 2022
308528b
Merge pull request #958 from daniel-beck/fix-link
aeisenberg Mar 4, 2022
44198be
1.1.4
invalid-email-address Mar 7, 2022
a33ae09
Update CHANGELOG.md
hmakholm Mar 7, 2022
e75fa83
Update CHANGELOG.md
hmakholm Mar 7, 2022
701b6a5
Update CHANGELOG.md
hmakholm Mar 7, 2022
1f44993
Update CHANGELOG.md
hmakholm Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md 
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
  • Loading branch information
@hmakholm @aeisenberg
hmakholm and aeisenberg authored Mar 7, 2022
commit 701b6a5569ac6833a2a19a58a5eec6b77db6fe47
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Update default CodeQL bundle version to 2.8.2. [#950](https://github.com/github/codeql-action/pull/950)
- Fix a bug where old results can be uploaded if the languages in a repository change when using a non-ephemeral self-hosted runner. [#955](https://github.com/github/codeql-action/pull/955)
hmakholm marked this conversation as resolved.
Show resolved Hide resolved
- Fail with a meaningful error message for Windows 11 and Windows Server 2022 which are currently unsupported. [#869](https://github.com/github/codeql-action/pull/869)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @hmakholm's earlier comment is correct: 2.8.2 introduces support for Windows 11, so we should instead highlight that (or reference the 2.8.2 change notes). @criemen to confirm.

Also if I'm reading the generated PR summary correctly, this mergeback PR does not contain #869; it contains #948 which is the revert of #869.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. My mistake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm 2.8.2 introduces W11 support.
I don't think this should go in the action changelog, as the action now just delegates to the CLI about W11 supports presence/absence, and that's mainly controlled by what's in the toolcache.


## 1.1.3 - 23 Feb 2022

Expand Down