Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple uploads in a single job #801

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Allow multiple uploads in a single job #801

merged 2 commits into from
Nov 15, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Oct 29, 2021 •
edited
Loading

They must all have a unique category.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner October 29, 2021 18:32
adityasharad
adityasharad reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I didn't know we had this mechanism and it's pretty neat to avoid user errors. Some suggestions for making that experience even nicer.

CHANGELOG.md Outdated Show resolved Hide resolved
src/upload-lib.ts Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.test.ts Show resolved Hide resolved
@aeisenberg aeisenberg force-pushed the aeisenberg/upload-by-category branch 3 times, most recently from 1a58b06 to 1ca3998 Compare November 3, 2021 23:22
@aeisenberg aeisenberg closed this Nov 3, 2021
@aeisenberg aeisenberg force-pushed the aeisenberg/upload-by-category branch from 1ca3998 to 8f0825e Compare November 3, 2021 23:53
@aeisenberg aeisenberg reopened this Nov 3, 2021
@aeisenberg aeisenberg marked this pull request as draft November 4, 2021 01:26
@aeisenberg aeisenberg force-pushed the aeisenberg/upload-by-category branch 5 times, most recently from b4f7319 to 4764f83 Compare November 4, 2021 03:57
@aeisenberg
Copy link
Contributor Author

Failing Debug artifact upload check is unrelated.

@aeisenberg aeisenberg marked this pull request as ready for review November 4, 2021 17:39
@cklin cklin self-requested a review November 15, 2021 16:47
@aeisenberg
Allow multiple uploads in a single job
6a98a4b 
They must all have a unique category. The category will be
converted into an environment variable.
@aeisenberg aeisenberg force-pushed the aeisenberg/upload-by-category branch from 81bd9bd to 6a98a4b Compare November 15, 2021 17:17
@aeisenberg aeisenberg enabled auto-merge November 15, 2021 18:33
@aeisenberg aeisenberg merged commit bbf0a22 into main Nov 15, 2021
@aeisenberg aeisenberg deleted the aeisenberg/upload-by-category branch November 15, 2021 18:57
@github-actions github-actions bot mentioned this pull request Nov 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasharad adityasharad adityasharad left review comments

@cklin cklin cklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aeisenberg @cklin @adityasharad