Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databases URL #612

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Update databases URL #612

merged 3 commits into from
Jul 14, 2021

Conversation

robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Jul 2, 2021

We're changing the URL used to upload databases to include "codeql" as well as "code scanning". This should make it more clear what the URL is for and unnecessarily box us in if we want to add other aspects to this API. The API side has been updated to allow both the old and new URLs, so now we can change things over here.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@robertbrignull robertbrignull marked this pull request as ready for review July 13, 2021 13:12
@robertbrignull robertbrignull requested a review from a team as a code owner July 13, 2021 13:12
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, except for the code scanning warning.

src/database-upload.ts Outdated Show resolved Hide resolved
@robertbrignull robertbrignull merged commit 4aa2d05 into main Jul 14, 2021
@robertbrignull robertbrignull deleted the robertbrignull/databases_url branch July 14, 2021 14:30
@github-actions github-actions bot mentioned this pull request Jul 19, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants