Skip to content

Conversation

@kaspersv
Copy link
Contributor

@kaspersv kaspersv commented Nov 13, 2025

During development of overlay analysis the action has restricted overlay analysis to the dsp-testing and github organisations. This PR removes this hardcoded restriction in preparation for wider rollout of overlay analysis. Overlay analysis is still feature flagged.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • Default setup - Impacts users who use default setup.
  • Code Scanning - Impacts Code Scanning (i.e. analysis-kinds: code-scanning).
  • Code Quality - Impacts Code Quality (i.e. analysis-kinds: code-quality).

How did/will you validate this change?

  • Test repository - This change will be tested on a test repository before merging.
  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.
  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@kaspersv kaspersv force-pushed the kaspersv/remove-overlay-org-restriction branch from 682943e to 5091e42 Compare November 13, 2025 09:48
@github-actions github-actions bot added the size/S Should be easy to review label Nov 13, 2025
@kaspersv kaspersv marked this pull request as ready for review November 13, 2025 10:12
@kaspersv kaspersv requested a review from a team as a code owner November 13, 2025 10:12
@kaspersv kaspersv requested review from Copilot and mbg November 13, 2025 10:12
Copilot finished reviewing on behalf of kaspersv November 13, 2025 10:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the hardcoded repository owner restriction for overlay analysis in preparation for wider rollout. The change eliminates checks that limited overlay analysis to only the dsp-testing and github organizations, while the feature remains behind feature flags.

Key Changes:

  • Removed repository owner validation logic from overlay analysis feature enablement
  • Simplified function signatures by removing the repository parameter from isOverlayAnalysisFeatureEnabled and getOverlayDatabaseMode
  • Consolidated and simplified test cases to remove repository-specific test scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/config-utils.ts Removed repository parameter and owner check from overlay analysis functions
src/config-utils.test.ts Updated test setup to remove repository owner field and consolidated duplicate test cases
lib/init-action.js Auto-generated JavaScript reflecting the TypeScript changes (not reviewed per guidelines)

Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kaspersv kaspersv merged commit 85f1517 into main Nov 14, 2025
480 checks passed
@kaspersv kaspersv deleted the kaspersv/remove-overlay-org-restriction branch November 14, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants