Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7434149
Upgrade Node.js version to 24.
mario-campos Sep 26, 2025
30445af
Rebuild JS after upgrading to Node.js 24.
mario-campos Sep 26, 2025
d7ada03
Downgrade upload-sarif@v4 -> v3
mario-campos Sep 26, 2025
1804381
Specify Node.js v24 in actions/setup-node steps.
mario-campos Sep 29, 2025
d4bbcb7
Implement simultaneous PR checks for Node.js v20, v24.
mario-campos Sep 29, 2025
d4b5380
Document Node.js 24 change in CHANGELOG.md.
mario-campos Sep 30, 2025
3adb1ff
Reorder supported tags in descending order
mario-campos Oct 1, 2025
d899b2e
Merge branch 'main' into mario-campos/node24
henrymercer Oct 2, 2025
205744e
Update changelog and version after v3.30.6
github-actions[bot] Oct 2, 2025
70836b1
Rebuild
github-actions[bot] Oct 2, 2025
21a7ba3
Merge pull request #3173 from github/mergeback/v3.30.6-to-main-64d10c13
nickrolfe Oct 2, 2025
65e9e64
Make `matrix` available to `start-proxy` action
mbg Oct 2, 2025
54ae8ba
Simplify PR check by reverting changes to `@types/node`.
mario-campos Oct 2, 2025
dddf033
Revert changes to build.mjs
mario-campos Oct 2, 2025
7fb8378
Re-throw exception in `createStatusReportBase` when in test mode
mbg Oct 3, 2025
065c6cf
Merge pull request #3174 from github/mbg/fix/start-proxy-matrix
mbg Oct 3, 2025
b2e2232
Merge remote-tracking branch 'origin/main' into mario-campos/node24
mario-campos Oct 3, 2025
b66db86
Hoist CHANGELOG note back to "UNRELEASED" section.
mario-campos Oct 6, 2025
5528384
Merge pull request #3169 from github/mario-campos/node24
mario-campos Oct 6, 2025
93c1673
Update changelog for v4.30.7
github-actions[bot] Oct 6, 2025
e296a93
Merge pull request #3183 from github/update-v4.30.7-55283843c
mario-campos Oct 7, 2025
b264e15
Update version and changelog for v3.30.7
github-actions[bot] Oct 7, 2025
01f1a24
Downgrade action.yml to use Node.js 20 instead of Node.js 24 for v3
mario-campos Oct 7, 2025
c551c50
Rebuild
github-actions[bot] Oct 7, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement simultaneous PR checks for Node.js v20, v24.
Copied from #2006.
  • Loading branch information
mario-campos committed Sep 30, 2025
commit d4bbcb74ca9400cb92146ef4ea5e441eafd2edce
12 changes: 9 additions & 3 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [20, 24]
permissions:
contents: read
security-events: write # needed to upload ESLint results
Expand All @@ -36,7 +37,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v5
with:
node-version: 24
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Set up Python
Expand All @@ -51,7 +52,12 @@ jobs:
npm config set script-shell bash
npm ci

- name: Verify compiled JS up to date
- name: Verify compiled JS up to date (Node.js 20)
if: matrix.node-version == 20
run: .github/workflows/script/check-js-20.sh

- name: Verify compiled JS up to date (Node.js 24)
if: matrix.node-version == 24
run: .github/workflows/script/check-js.sh

- name: Verify PR checks up to date
Expand All @@ -73,7 +79,7 @@ jobs:

- name: Upload sarif
uses: github/codeql-action/upload-sarif@v3
if: matrix.os == 'ubuntu-latest'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == 24
with:
sarif_file: eslint.sarif
category: eslint
Expand Down
37 changes: 37 additions & 0 deletions .github/workflows/script/check-js-20.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#!/bin/bash
set -eu

# Change @types/node to v20 temporarily to check that the generated JS files are correct.
contents=$(jq '.devDependencies."@types/node" = "^20.0.0"' package.json)
echo "${contents}" > package.json

npm install

if [ ! -z "$(git status --porcelain)" ]; then
git config --global user.email "github-actions@github.com"
git config --global user.name "github-actions[bot]"
# The period in `git add --all .` ensures that we stage deleted files too.
git add --all .
git commit -m "Use @types/node v20"
fi

# Wipe the lib directory in case there are extra unnecessary files in there
rm -rf lib

# Generate the JavaScript files
npm run-script build

# Check that repo is still clean.
# The downgrade of @types/node means that we expect certain changes to the generated JS files.
# Therefore, we should ignore these changes to @types/node and check for outstanding changes.
if [[ $(git diff | grep --perl-regexp '^-(?!--)' | grep --count --invert-match --perl-regexp '"@types/node": "\^24') -gt 0 || \
$(git diff | grep --perl-regexp '^\+(?!\+\+)' | grep --count --invert-match --perl-regexp '"@types/node": "\^20') -gt 0 ]]
then
>&2 echo "Failed: JavaScript files are not up to date. Run 'rm -rf lib && npm run-script build' to update"
git diff
exit 1
fi
echo "Success: JavaScript files are up to date"

# Clean up changes to package.json, package-lock.json, and lib/*.js.
git reset --hard HEAD~1