Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Oct 2, 2025

This mirrors what we have for the other actions. Used by createStatusReportBase. I considered changing getRequiredInput("matrix") to getOptionalInput("matrix") there (and think that makes sense as a change), but thought it would be useful to have the matrix value in the start-proxy telemetry as well if it is available.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Oct 2, 2025
@mbg mbg requested a review from a team as a code owner October 2, 2025 16:47
@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 16:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This change adds the matrix input parameter to the start-proxy action, making it consistent with other actions in the codebase. The matrix value is used by createStatusReportBase and will enable matrix information to be included in start-proxy telemetry.

Key Changes

  • Added matrix input parameter to start-proxy/action.yml with default value from GitHub Actions matrix context
  • Maintained consistency with existing action interfaces by making the parameter optional

@mbg mbg requested a review from henrymercer October 3, 2025 11:06
@mbg
Copy link
Member Author

mbg commented Oct 3, 2025

You coordinated those reviews very well @henrymercer and @esbena 😄 within a few seconds of each other!

@mbg mbg merged commit 065c6cf into main Oct 3, 2025
233 checks passed
@mbg mbg deleted the mbg/fix/start-proxy-matrix branch October 3, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants